[SPARK-54244][Geo][SQL] Introduce type coercion support for GEOMETRY data types #52945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Member
|
Please resolve the conflicts, @uros-db . |
uros-db
changed the title
dongjoon-hyun
approved these changes
Nov 8, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @uros-db .
Contributor
Author
|
@dongjoon-hyun All checks good, ready to merge to master & 4.1. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 8, 2025
…data types ### What changes were proposed in this pull request? Implement least common type (LCT) logic for `GEOMETRY` types, as follows: - LCT for GeometryType(`srid_1`) and GeometryType(`srid_1`) is: GeometryType(`srid_1`) - LCT for GeometryType(`srid_1`) and GeometryType(`srid_2`) is: GeometryType(`ANY`) - LCT for GeometryType(`srid_1`) and GeometryType(`ANY`) is: GeometryType(`ANY`) - LCT for GeometryType(`ANY`) and GeometryType(`ANY`) is: GeometryType(`ANY`) In other words, the mixed SRID `GEOMETRY` type is the *common type* for all GEOMETRY types. ### Why are the changes needed? Introducing LCT and type coercion logic in the geospatial data type system. ### Does this PR introduce _any_ user-facing change? Yes, type coercion is now supported for `GeometryType`. ### How was this patch tested? Added tests for geometry type coercion: - `AnsiTypeCoercionSuite` - `TypeCoercionSuite` Added appropriate Scala suite unit tests: - `STExpressionsSuite` Added appropriate end-to-end SQL tests: - `st-functions` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52945 from uros-db/geo-coercion-geom. Authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 9b68d3c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement least common type (LCT) logic for
GEOMETRYtypes, as follows:srid_1) and GeometryType(srid_1) is: GeometryType(srid_1)srid_1) and GeometryType(srid_2) is: GeometryType(ANY)srid_1) and GeometryType(ANY) is: GeometryType(ANY)ANY) and GeometryType(ANY) is: GeometryType(ANY)In other words, the mixed SRID
GEOMETRYtype is the common type for all GEOMETRY types.Why are the changes needed?
Introducing LCT and type coercion logic in the geospatial data type system.
Does this PR introduce any user-facing change?
Yes, type coercion is now supported for
GeometryType.How was this patch tested?
Added tests for geometry type coercion:
AnsiTypeCoercionSuiteTypeCoercionSuiteAdded appropriate Scala suite unit tests:
STExpressionsSuiteAdded appropriate end-to-end SQL tests:
st-functionsWas this patch authored or co-authored using generative AI tooling?
No.